-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Usage Collection] Add schema to stack_management
#77897
[Usage Collection] Add schema to stack_management
#77897
Conversation
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
fd10857
to
8779c41
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
'timelion:es.default_index': { type: 'keyword' }, | ||
'timelion:showTutorial': { type: 'boolean' }, | ||
'securitySolution:timeDefaults': { type: 'keyword' }, | ||
'securitySolution:defaultAnomalyScore': { type: 'long' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a trial license, I didn't get this field in the usage data payload. There are a lot of fields though and I might have missed it.
import { UsageStats } from './telemetry_management_collector'; | ||
|
||
// Retrieved by changing all the current settings in Kibana (we'll need to revisit it in the future). | ||
// I would suggest we use flattened type for the mappings of this collector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flattened field types won't allow us to do aggregations and answer questions such as: "what is the average precision used in tile maps?" or "what is the average size of terms aggregations users set in Discover?"
|
||
export type UsageStats = Record<string, any>; | ||
export interface UsageStats extends Record<string, boolean | number | string> { | ||
// We don't support `type` yet. Only interfaces. So I added at least 1 known key to the generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tech debt is reasonable here. We can handle it together with any other larger changes we need to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort at extracting all those fields! It will come in very handy when we create our usage data dictionary.
LGTM
…ema/stack_management
…/kibana into telemetry/schema/stack_management
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
…78417) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Pinging @elastic/kibana-core (Team:Core) |
Summary
schema
definition to the collectorstack_management
.check_collector_integrity
to support keys with'
in the key name.Related to #70180.
For maintainers